Skip to content

Add upsert tests #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add upsert tests #4454

wants to merge 3 commits into from

Conversation

dminor
Copy link
Contributor

@dminor dminor commented Apr 15, 2025

These tests are currently being executed in SpiderMonkey as non262 tests, and were exported using the test262-export.py script. Linting errors were then corrected.

These tests are currently being executed in SpiderMonkey as `non262` tests,
and were exported using the `test262-export.py` script. Linting errors
were then corrected.
@dminor dminor requested review from a team as code owners April 15, 2025 13:38
@dminor dminor mentioned this pull request Apr 14, 2025
17 tasks
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This is staging, so you should feel free to (and already have the appropriate permissions to) commit these as long as they are executable by other engines' test262 harnesses.

That said, I suspect they will not pass in any other engines unless you add includes: [sm/non262.js, sm/non262-shell.js] to each one.

Optionally, there's also some low-hanging fruit that could make them slightly more ready to move out of staging when the time comes:

  • Add a feature for the upsert proposal to features.txt and add it to features in the frontmatter of each test
  • Use verifyProperty instead of assert.deepEqual(Object.getOwnPropertyDescriptor(...etc))
  • Use assert.throws(ExceptionType, function () { ... }) instead of assertThrowsInstanceOf(function () { ... }, ExceptionType)

@dminor
Copy link
Contributor Author

dminor commented Apr 24, 2025

Thanks for the suggestions on how to fix these up, I'll look into that next week prior to committing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants