-
Notifications
You must be signed in to change notification settings - Fork 149
Switch to hadolint-py and add shellcheck-py #3604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not had much experience with pre-commit-ci, but iirc it rebases open PRs, so I am ok with either this or renovate as a tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since renovate addition should handle the rebases part, LGTM
622b742
to
2ccee52
Compare
Added pre-commit ci app to teemtee/tmt |
2ccee52
to
6bb1286
Compare
f793f42
to
925d1ff
Compare
oof nodejs binaries 190MB. Stupid javascript. |
be6bedc
to
523f6c5
Compare
Nothing is ever easy. And now: https://results.pre-commit.ci/run/github/206777717/1745947600.41gGYLi9Qe2q90n6v-OCrw Not sure if the tmt-lint works with the |
39bdc8a
to
b2888e5
Compare
ok, reverting to github workflow. Keeping hadolint and shellcheck changes. |
Seems harmless & pre-commit only, merging without more checks. |
pre-commit.ci doesn't play ball with pyright. For now, reverting to github workflow. Keeping hadolint-py and shellcheck-py