Skip to content

Switch to hadolint-py and add shellcheck-py #3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Switch to hadolint-py and add shellcheck-py #3604

merged 2 commits into from
May 5, 2025

Conversation

martinhoyer
Copy link
Collaborator

@martinhoyer martinhoyer commented Mar 15, 2025

See: https://pre-commit.ci/

In order for it to work, it requires adding pre-commit.ci in gh organization settings. (not doing that without consensus)

Can go hand-in-hand with #2923

One motivation is to keep the checks autoupdated, for example #3544 (comment)

GitHub action:

this action is in maintenance-only mode and will not be accepting new features.
generally you want to use pre-commit.ci which is faster and has more features.

pre-commit.ci will always be free for open source repositories.
Also adding shellcheck.py while keeping the shellcheck action - Closes #2271

pre-commit.ci doesn't play ball with pyright. For now, reverting to github workflow. Keeping hadolint-py and shellcheck-py

Copy link
Contributor

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not had much experience with pre-commit-ci, but iirc it rebases open PRs, so I am ok with either this or renovate as a tool.

@martinhoyer martinhoyer self-assigned this Mar 25, 2025
@happz happz added this to planning Apr 3, 2025
@github-project-automation github-project-automation bot moved this to backlog in planning Apr 3, 2025
@happz happz moved this from backlog to review in planning Apr 3, 2025
@psss psss added this to the 1.47 milestone Apr 10, 2025
@psss psss modified the milestones: 1.47, 1.48 Apr 23, 2025
Copy link
Collaborator

@skycastlelily skycastlelily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

Copy link
Collaborator

@mcasquer mcasquer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since renovate addition should handle the rebases part, LGTM

@martinhoyer martinhoyer moved this from review to merge in planning Apr 29, 2025
@happz happz added the test coverage Improvements or additions to test coverage of tmt itself label Apr 29, 2025
@martinhoyer
Copy link
Collaborator Author

Added pre-commit ci app to teemtee/tmt

@martinhoyer martinhoyer moved this from merge to review in planning Apr 29, 2025
@martinhoyer
Copy link
Collaborator Author

exceeds tier max size 250MiB: 253.5MiB

oof nodejs binaries 190MB. Stupid javascript.

@martinhoyer martinhoyer force-pushed the pre-commit-ci branch 3 times, most recently from be6bedc to 523f6c5 Compare April 29, 2025 17:06
@martinhoyer
Copy link
Collaborator Author

Nothing is ever easy.
For context - original failures: https://results.pre-commit.ci/run/github/206777717/1745941884.ILAZsf-0RJOXnlmnttSSTQ

And now: https://results.pre-commit.ci/run/github/206777717/1745947600.41gGYLi9Qe2q90n6v-OCrw
RobertCraigie/pyright-python#345

Not sure if the tmt-lint works with the - GIT_DEPTH: "1" or not now.

@happz happz moved this from review to implement in planning Apr 30, 2025
@martinhoyer martinhoyer changed the title Switch from pre-commit gh action to pre-commit.ci Switch to hadolint-py and add shellcheck-py Apr 30, 2025
@martinhoyer
Copy link
Collaborator Author

ok, reverting to github workflow. Keeping hadolint and shellcheck changes.

@martinhoyer martinhoyer moved this from implement to review in planning Apr 30, 2025
@happz happz moved this from review to merge in planning May 5, 2025
@happz
Copy link
Collaborator

happz commented May 5, 2025

Seems harmless & pre-commit only, merging without more checks.

@happz happz merged commit 9b77c6f into main May 5, 2025
13 of 23 checks passed
@happz happz deleted the pre-commit-ci branch May 5, 2025 08:48
@github-project-automation github-project-automation bot moved this from merge to done in planning May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test coverage Improvements or additions to test coverage of tmt itself
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

Run shellcheck in pre-commit
7 participants