Skip to content

fix(view): InvalidClosingTag should ignore commented out code attributes #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(view): InvalidClosingTag should ignore commented out code attributes #1288

wants to merge 2 commits into from

Conversation

erikaraujo
Copy link
Contributor

This PR introduces a failing test for #1287.

The issue seems to be a combination of the code being commented out and the /svg part of the xmlns attribute of the svg tag in the following snippet:

<h1>
    <!-- <svg xmlns="http://www.w3.org/2000/svg">
    </svg> -->
</h1>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erikaraujo