Skip to content

Commit 7e83f8e

Browse files
authored
Add ➕ icon (#6408)
## Motivation for features / changes The hparams in time series project needs a plus icon for the add column button. ## Technical description of changes ### How do you add icons? 1) Find the icon you want to add here https://github.com/google/material-design-icons 2) Get the raw icon you want to add by clicking the "Raw" button 3) Download the file and get the checksum `wget -O output.svg $FILE && sha256sum output.svg` 4) Finally a googler must follow the instructions here to update the tensorflow mirror [go/tensorboard-tf-mirror](http://goto/tensorboard-tf-mirror) ## Screenshots of UI changes (or N/A) Look! There's an icon? ![image](https://github.com/tensorflow/tensorboard/assets/78179109/e270fb83-4180-406e-bf9a-f38511357bba)
1 parent fd75a84 commit 7e83f8e

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

tensorboard/webapp/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,7 @@ tf_svg_bundle(
319319
# //tensorboard/webapp/testing/mat_icon_module.ts.
320320
# 'com_google_material_design_icon' in third_party/js.bzl
321321
srcs = [
322+
"@com_google_material_design_icon//:add_24px.svg",
322323
"@com_google_material_design_icon//:arrow_downward_24px.svg",
323324
"@com_google_material_design_icon//:arrow_upward_24px.svg",
324325
"@com_google_material_design_icon//:brightness_6_24px.svg",

third_party/js.bzl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,10 @@ def tensorboard_js_workspace():
202202
"http://mirror.tensorflow.org/raw.githubusercontent.com/google/material-design-icons/3.0.1/action/svg/production/ic_change_history_24px.svg",
203203
"https://raw.githubusercontent.com/google/material-design-icons/3.0.1/action/svg/production/ic_change_history_24px.svg",
204204
],
205+
"475c29758b4a689598f80099714362c0340ad3a4bc111e2d88807bbf4b0f817e": [
206+
"http://mirror.tensorflow.org/raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/content/add/materialicons/24px.svg",
207+
"https://raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/content/add/materialicons/24px.svg",
208+
],
205209
},
206210
rename = {
207211
"ic_arrow_downward_24px.svg": "arrow_downward_24px.svg",
@@ -266,5 +270,7 @@ def tensorboard_js_workspace():
266270
"https://raw.githubusercontent.com/google/material-design-icons/d3d4aca5a7cf50bc68bbd401cefa708e364194e8/src/image/brightness_6/materialicons/24px.svg": "brightness_6_24px.svg",
267271
"http://mirror.tensorflow.org/raw.githubusercontent.com/google/material-design-icons/d3d4aca5a7cf50bc68bbd401cefa708e364194e8/src/action/drag_indicator/materialicons/24px.svg": "drag_indicator_24px.svg",
268272
"https://raw.githubusercontent.com/google/material-design-icons/d3d4aca5a7cf50bc68bbd401cefa708e364194e8/src/action/drag_indicator/materialicons/24px.svg": "drag_indicator_24px.svg",
273+
"http://mirror.tensorflow.org/raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/content/add/materialicons/24px.svg": "add_24px.svg",
274+
"https://raw.githubusercontent.com/google/material-design-icons/b3f05bfbf4329a5b63f50a720f867c2bac163f98/src/content/add/materialicons/24px.svg": "add_24px.svg",
269275
},
270276
)

0 commit comments

Comments
 (0)