Skip to content

Add ➕ icon #6408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023
Merged

Add ➕ icon #6408

merged 1 commit into from
May 31, 2023

Conversation

rileyajones
Copy link
Contributor

@rileyajones rileyajones commented May 31, 2023

Motivation for features / changes

The hparams in time series project needs a plus icon for the add column button.

Technical description of changes

How do you add icons?

  1. Find the icon you want to add here https://github.com/google/material-design-icons
  2. Get the raw icon you want to add by clicking the "Raw" button
  3. Download the file and get the checksum wget -O output.svg $FILE && sha256sum output.svg
  4. Finally a googler must follow the instructions here to update the tensorflow mirror go/tensorboard-tf-mirror

Screenshots of UI changes (or N/A)

Look! There's an icon?
image

@rileyajones rileyajones requested a review from japie1235813 May 31, 2023 16:02
Copy link
Contributor

@japie1235813 japie1235813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing down the steps!

@rileyajones rileyajones merged commit 7e83f8e into tensorflow:master May 31, 2023
rileyajones added a commit that referenced this pull request Jun 15, 2023
## Motivation for features / changes
We need these new icons to expand and collapse the runs table for the
hparams in time series feature.

## Technical description of changes

See #6408 for how icons are added
@qihach64 qihach64 mentioned this pull request Dec 15, 2023
qihach64 added a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants