-
Notifications
You must be signed in to change notification settings - Fork 246
feat(GKE): Add secondary boot disk sample for preloaded data #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GKE): Add secondary boot disk sample for preloaded data #684
Conversation
Here is the summary of changes. You are about to add 3 region tags.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
/gcbrun |
1 similar comment
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aston-github!
The "renamed" tag was brand new: #675
VCR test was failing due to a panic during type assertion in expandNodeConfig. I submitted changes in magic-modules to gracefully handle the config type assertion in hashicorp/terraform-provider-google#18323 . I added a near identical test case to the acceptance test in magic-modules, which passed. Machine type is the only difference. |
Unclear why the test is failing, seems like @aston-github - maybe try amending your last commit? (or similar) |
/gcbrun |
OK - The CI test appears to be running correctly after the new commit. |
/gcbrun |
/gcbrun |
Description
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/kubernetes-engine/docs/how-to/data-container-image-preloading
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review