Skip to content

feat(GKE): Add secondary boot disk sample for preloaded data #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aston-github
Copy link
Contributor

@aston-github aston-github commented May 30, 2024

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@aston-github aston-github requested review from a team as code owners May 30, 2024 22:44
Copy link

snippet-bot bot commented May 30, 2024

Here is the summary of changes.

You are about to add 3 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@apeabody apeabody changed the title Add secondary boot disk sample for preloaded data use case. feat(GKE): Add secondary boot disk sample for preloaded data May 30, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@aston-github
Copy link
Contributor Author

/gcbrun

1 similar comment
@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aston-github!

The "renamed" tag was brand new: #675

@aston-github
Copy link
Contributor Author

VCR test was failing due to a panic during type assertion in expandNodeConfig. I submitted changes in magic-modules to gracefully handle the config type assertion in hashicorp/terraform-provider-google#18323 . I added a near identical test case to the acceptance test in magic-modules, which passed. Machine type is the only difference.

@apeabody
Copy link
Contributor

apeabody commented Jun 4, 2024

Unclear why the test is failing, seems like ${_BASE_BRANCH} isn't being populated for some reason?

@aston-github - maybe try amending your last commit? (or similar)

@apeabody
Copy link
Contributor

apeabody commented Jun 5, 2024

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Jun 5, 2024

OK - The CI test appears to be running correctly after the new commit.

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody merged commit aa7ca37 into terraform-google-modules:main Jun 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants