-
Notifications
You must be signed in to change notification settings - Fork 246
feat(application integration): Add oidc token sample for creating auth configs #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the summary of changes. You are about to add 3 region tags.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
@@ -16,11 +16,21 @@ | |||
|
|||
provider "google" {} | |||
|
|||
# [START application_integration_create_auth_config_auth_token] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving this line means that you will no longer include the resource in the region tag. This may need to be changed later.
/gcbrun |
Integration tests failed with the following message:
(wrapped for readability) Previously in #658 we were iterating on this, but this PR doesn't include any IAM resources. Can you confirm what permisions are needed and add them to this PR? Thanks! |
Co-authored-by: Rohit Jangid <[email protected]>
/gcbrun |
Co-authored-by: Rohit Jangid <[email protected]>
/gcbrun |
/gcbrun |
Co-authored-by: Rohit Jangid <[email protected]>
/gcbrun |
CICD seem failed with the error reported @ #689 (comment) |
@pay20 - PTAL with provided comments. |
/gcbrun |
/gcbrun |
cl/657845149 |
Description
Add oidc token sample for creating auth configs
Fixes: b/344572436
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
[ *] I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
Location(s): https://cloud.google.com/application-integration/docs/configure-authentication-profiles#terraform
API enablement
Review