Skip to content

feat: upgraded versions.tf to include minor bumps from tpg v5 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# Make will use bash instead of sh
SHELL := /usr/bin/env bash

DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 1.13
DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 1.17
DOCKER_IMAGE_DEVELOPER_TOOLS := cft/developer-tools
REGISTRY_URL := gcr.io/cloud-foundation-cicd

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ don't you run the risk of failing validation (at the least) or surfacing the
dreaded `value of 'count' cannot be computed` error. Future versions of
Terraform may change this fact, but this is the current limitation.

[^]: (autogen_docs_start)
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
## Inputs

| Name | Description | Type | Default | Required |
Expand Down Expand Up @@ -213,7 +213,7 @@ Terraform may change this fact, but this is the current limitation.
| reverse\_dns\_fqdns | List of reverse DNS PTR records registered in Cloud DNS. (e.g. ["1.2.11.10.in-addr.arpa", "2.2.11.10.in-addr.arpa"]) |
| self\_links | List of URIs of the created address resources |

[^]: (autogen_docs_end)
<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->


## Requirements
Expand Down
10 changes: 5 additions & 5 deletions build/int.cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ steps:
args: ['/bin/bash', '-c', 'cft test run TestIpAddressOnly --verbose --stage teardown']
- id: create ip-address-with-specific-ip-local
waitFor:
- prepare
- destroy ip-address-only-local
name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
args: ['/bin/bash', '-c', 'cft test run TestIpAddressWithSpecificIp --verbose --stage init']
- id: converge ip-address-with-specific-ip-local
Expand All @@ -63,7 +63,7 @@ steps:
args: ['/bin/bash', '-c', 'cft test run TestIpAddressWithSpecificIp --verbose --stage teardown']
- id: create TestDnsForwardExample
waitFor:
- prepare
- destroy ip-address-with-specific-ip-local
name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
args: ['/bin/bash', '-c', 'cft test run TestDnsForwardExample --verbose --stage init']
- id: converge TestDnsForwardExample
Expand All @@ -83,7 +83,7 @@ steps:
args: ['/bin/bash', '-c', 'cft test run TestDnsForwardExample --verbose --stage teardown']
- id: create TestDnsForwardExampleMultiNames
waitFor:
- prepare
- destroy TestDnsForwardExample
name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
args: ['/bin/bash', '-c', 'cft test run TestDnsForwardExampleMultiNames --verbose --stage init']
- id: converge TestDnsForwardExampleMultiNames
Expand All @@ -103,7 +103,7 @@ steps:
args: ['/bin/bash', '-c', 'cft test run TestDnsForwardExampleMultiNames --verbose --stage teardown']
- id: create TestDnsForwardAndReverse
waitFor:
- prepare
- destroy TestDnsForwardExampleMultiNames
name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
args: ['/bin/bash', '-c', 'cft test run TestDnsForwardAndReverse --verbose --stage init ']
- id: converge TestDnsForwardAndReverse
Expand All @@ -126,6 +126,6 @@ tags:
- 'integration'
substitutions:
_DOCKER_IMAGE_DEVELOPER_TOOLS: 'cft/developer-tools'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '1.13'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '1.17'
options:
machineType: 'N1_HIGHCPU_8'
2 changes: 1 addition & 1 deletion build/lint.cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ tags:
- 'lint'
substitutions:
_DOCKER_IMAGE_DEVELOPER_TOOLS: 'cft/developer-tools'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '1.13'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '1.17'
options:
machineType: 'N1_HIGHCPU_8'
4 changes: 2 additions & 2 deletions examples/dns_forward_and_reverse/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This example illustrates how to reserve multiple IP addresses at the same
time, and how to enable the Google Cloud DNS registration functionality for
both forward and reverse DNS lookup zones.

[^]: (autogen_docs_start)
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
## Inputs

| Name | Description | Type | Default | Required |
Expand Down Expand Up @@ -32,7 +32,7 @@ both forward and reverse DNS lookup zones.
| reverse\_dns\_fqdns | List of reverse DNS PTR records registered in Cloud DNS. |
| reverse\_zone | The GCP name of the reverse lookup DNS zone being used |

[^]: (autogen_docs_end)
<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

To provision this example, run the following from within this directory:
- `terraform init` to get the plugins
Expand Down
3 changes: 1 addition & 2 deletions examples/dns_forward_and_reverse/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ terraform {
required_version = ">= 0.13"
required_providers {
google = {
source = "hashicorp/google"
version = "~> 4.0"
source = "hashicorp/google"
}
}
}
4 changes: 2 additions & 2 deletions examples/dns_forward_example/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ time, and how to enable the Google Cloud DNS registration functionality that
will register the IP addresses and their corresponding DNS names with Google
Cloud DNS.

[^]: (autogen_docs_start)
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
## Inputs

| Name | Description | Type | Default | Required |
Expand All @@ -30,7 +30,7 @@ Cloud DNS.
| project\_id | ID of the project being used |
| region | Region being used |

[^]: (autogen_docs_end)
<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

To provision this example, run the following from within this directory:
- `terraform init` to get the plugins
Expand Down
3 changes: 1 addition & 2 deletions examples/dns_forward_example/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ terraform {
required_version = ">= 0.13"
required_providers {
google = {
source = "hashicorp/google"
version = "~> 4.0"
source = "hashicorp/google"
}
}
}
3 changes: 1 addition & 2 deletions examples/global_external_address/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ terraform {
required_version = ">= 0.13"
required_providers {
google = {
source = "hashicorp/google"
version = "~> 4.0"
source = "hashicorp/google"
}
null = {
source = "hashicorp/null"
Expand Down
3 changes: 1 addition & 2 deletions examples/internal_with_dynamic_ip/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ terraform {
required_version = ">= 0.13"
required_providers {
google = {
source = "hashicorp/google"
version = ">= 3.53, < 5.0"
source = "hashicorp/google"
}
null = {
source = "hashicorp/null"
Expand Down
3 changes: 1 addition & 2 deletions examples/internal_with_specific_ip/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ terraform {
required_version = ">= 0.13"
required_providers {
google = {
source = "hashicorp/google"
version = ">= 3.53, < 5.0"
source = "hashicorp/google"
}
null = {
source = "hashicorp/null"
Expand Down
4 changes: 2 additions & 2 deletions examples/ip_address_only/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This example illustrates how to simply reserve an IP address that is
dynamically assigned by GCP. Outputs have been provided to list the address
itself as well as the resource name that corresponds.

[^]: (autogen_docs_start)
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
## Inputs

| Name | Description | Type | Default | Required |
Expand All @@ -23,7 +23,7 @@ itself as well as the resource name that corresponds.
| project\_id | ID of the project being used |
| region | Region being used |

[^]: (autogen_docs_end)
<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

To provision this example, run the following from within this directory:
- `terraform init` to get the plugins
Expand Down
3 changes: 1 addition & 2 deletions examples/ip_address_only/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ terraform {
required_version = ">= 0.13"
required_providers {
google = {
source = "hashicorp/google"
version = "~> 4.0"
source = "hashicorp/google"
}
}
}
4 changes: 2 additions & 2 deletions examples/ip_address_with_specific_ip/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
This example illustrates how to reserve a specific IP address (instead of
allowing GCP to dynamically assign it from the subnet provided).

[^]: (autogen_docs_start)
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
## Inputs

| Name | Description | Type | Default | Required |
Expand All @@ -23,7 +23,7 @@ allowing GCP to dynamically assign it from the subnet provided).
| project\_id | ID of the project being used |
| region | Region being used |

[^]: (autogen_docs_end)
<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

To provision this example, run the following from within this directory:
- `terraform init` to get the plugins
Expand Down
3 changes: 1 addition & 2 deletions examples/ip_address_with_specific_ip/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ terraform {
required_version = ">= 0.13"
required_providers {
google = {
source = "hashicorp/google"
version = "~> 4.0"
source = "hashicorp/google"
}
}
}
3 changes: 1 addition & 2 deletions examples/regional_external_address/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ terraform {
required_version = ">= 0.13"
required_providers {
google = {
source = "hashicorp/google"
version = ">= 3.53, < 5.0"
source = "hashicorp/google"
}
null = {
source = "hashicorp/null"
Expand Down
12 changes: 6 additions & 6 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ locals {
dns_forward_record_count = var.enable_cloud_dns ? length(local.dns_fqdns) : 0
dns_reverse_record_count = var.enable_reverse_dns ? length(local.dns_fqdns) : 0
ip_addresses = concat(
google_compute_address.ip.*.address,
google_compute_global_address.global_ip.*.address,
google_compute_address.ip[*].address,
google_compute_global_address.global_ip[*].address,
)
ip_names = concat(
google_compute_address.ip.*.name,
google_compute_global_address.global_ip.*.name,
google_compute_address.ip[*].name,
google_compute_global_address.global_ip[*].name,
)
self_links = concat(
google_compute_address.ip.*.self_link,
google_compute_global_address.global_ip.*.self_link,
google_compute_address.ip[*].self_link,
google_compute_global_address.global_ip[*].self_link,
)
prefix_length = var.address_type == "EXTERNAL" || (var.address_type == "INTERNAL" && var.purpose == "PRIVATE_SERVICE_CONNECT") ? null : var.prefix_length

Expand Down
4 changes: 2 additions & 2 deletions test/setup/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ terraform {
required_providers {
google = {
source = "hashicorp/google"
version = ">= 3.50, < 5.0"
version = ">= 3.50, < 6"
}
google-beta = {
source = "hashicorp/google-beta"
version = ">= 3.50, < 5.0"
version = ">= 3.50, < 6"
}
random = {
source = "hashicorp/random"
Expand Down
2 changes: 1 addition & 1 deletion versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ terraform {

google = {
source = "hashicorp/google"
version = ">= 3.53, < 5.0"
version = ">= 3.53, < 6"
}
}

Expand Down