feat: add storage_pools support #2326
Draft
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Hold till #2325 is released |
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
DrFaust92
force-pushed
the
storage-pools
branch
from
a8d8510 to
b1624ae
Compare
|
apeabody apologies, seems there is no need for node recreate and it is not a breaking change as i first thought. |
|
scratch that! https://github.com/modular-magician/terraform-provider-google/blob/downstream-pr-cab73525e01fb2ada73ae78520cf58ba1d45fc93/google/services/container/node_config.go#L440 there is a confusion in upstream. ill open a PR to fix it. meanwhile it can wait |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will require a major version bump