Skip to content

feat: add local_ssd_encryption_mode #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DrFaust92
Copy link
Contributor

  • some README formatting

@DrFaust92 DrFaust92 requested review from apeabody, ericyz and a team as code owners April 11, 2025 13:05
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

From the LINT:

1 issue(s) found:

Warning: [Fixable] variable "local_ssd_encryption_mode" is declared but not used (terraform_unused_declarations)

  on variables.tf line 438:
 438: variable "local_ssd_encryption_mode" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.10.0/docs/rules/terraform_unused_declarations.md

tflint failed ./modules/private-cluster 
Working in ./modules/private-cluster-update-variant using /root/tflint/.tflint.module.hcl...
1 issue(s) found:

Warning: [Fixable] variable "local_ssd_encryption_mode" is declared but not used (terraform_unused_declarations)

  on variables.tf line 438:
 438: variable "local_ssd_encryption_mode" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.10.0/docs/rules/terraform_unused_declarations.md

tflint failed ./modules/private-cluster-update-variant 

Signed-off-by: drfaust92 <[email protected]>
@DrFaust92 DrFaust92 marked this pull request as draft April 12, 2025 00:47
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

From the test:

        	Error Trace:	/builder/home/go/pkg/mod/github.com/gruntwork-io/[email protected]/modules/terraform/apply.go:34
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:571
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:630
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:669
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/utils/stages.go:31
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:669
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: expected node_pool.0.node_config.0.local_ssd_encryption_mode to be one of ["STANDARD_ENCRYPTION" "EPHEMERAL_KEY_ENCRYPTION"], got 
        	            	
        	            	  with module.example.module.gke.google_container_cluster.primary,
        	            	  on ../../../cluster.tf line 502, in resource "google_container_cluster" "primary":
        	            	 502:       local_ssd_encryption_mode = lookup(var.node_pools[0], "local_ssd_encryption_mode", "")
        	            	}
        	Test:       	TestDeployService

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants