Document update variants #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kopachevsky
commented
Dec 23, 2019
kopachevsky
commented
- Fix Document update variants #317
kopachevsky
force-pushed
the
issue/317/document_update
branch
2 times, most recently
from
a08bb78 to
c996e5c
Compare
kopachevsky
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
nick4fake
previously approved these changes
Dec 31, 2019
morgante
suggested changes
Jan 6, 2020
autogen/README.md
Outdated
| @@ -25,6 +25,27 @@ If you are using these features with a private cluster, you will need to either: | |||
| 3. Include the external IP of your Terraform deployer in the `master_authorized_networks` configuration. Note that only IP addresses reserved in Google Cloud (such as in other VPCs) can be whitelisted. | |||
| 4. Deploy a [bastion host](https://github.com/terraform-google-modules/terraform-google-bastion-host) or [proxy](https://cloud.google.com/solutions/creating-kubernetes-engine-private-clusters-with-net-proxies) in the same VPC as your GKE cluster. | |||
|
|
|||
| ## Private Cluster Update | |||
There was a problem hiding this comment.
Update variants are not specific to private clusters. Rather, this should be conditional based on whether update variant is true.
kopachevsky
force-pushed
the
issue/317/document_update
branch
2 times, most recently
from
681214e to
d0780e5
Compare
morgante
suggested changes
Jan 9, 2020
autogen/main/README.md
Outdated
| @@ -28,7 +28,30 @@ If you are using these features with a private cluster, you will need to either: | |||
| If you are going to isolate your GKE private clusters from internet access you could check [guide](https://medium.com/google-cloud/completely-private-gke-clusters-with-no-internet-connectivity-945fffae1ccd) and [repo](https://github.com/andreyk-code/no-inet-gke-cluster) | |||
|
|
|||
| {% endif %} | |||
| {% if update_variant %} | |||
| ## Private Cluster Update | |||
There was a problem hiding this comment.
Suggested change
| ## Private Cluster Update | |
| ## Node Pool Update Variant |
kopachevsky
force-pushed
the
issue/317/document_update
branch
from
d0780e5 to
89d5f45
Compare
kopachevsky
requested review from
morgante
and removed request for
aaron-lane
morgante
approved these changes
Jan 22, 2020
kri5
pushed a commit
to kri5/terraform-google-kubernetes-engine
that referenced
this pull request
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.