Skip to content

Fix default value and type of exclusion vars in modules #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2021
Merged

Fix default value and type of exclusion vars in modules #44

merged 4 commits into from
Mar 19, 2021

Conversation

danielseider
Copy link
Contributor

submodules were not adjusted when #32 was merged. Results in an 404 googleapi error when using submodules.

@danielseider danielseider requested review from averbuks, ludoo and a team as code owners March 18, 2021 19:45
@comment-bot-dev
Copy link

comment-bot-dev commented Mar 18, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante morgante merged commit 20b6a30 into terraform-google-modules:master Mar 19, 2021
@morgante
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@averbuks averbuks Awaiting requested review from averbuks

@ludoo ludoo Awaiting requested review from ludoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielseider @comment-bot-dev @morgante