Skip to content

Add ability to use existing Cloud Scheduler #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

omazin
Copy link
Contributor

@omazin omazin commented Dec 6, 2019

1st approach to solve #15

Copy link

@ocervell ocervell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work overall, a few things to improve (see comments)

@omazin omazin marked this pull request as ready for review December 18, 2019 13:20
@omazin omazin changed the title Existing cloud scheduler 1 Add ability to use existing Cloud Scheduler Dec 18, 2019
@ocervell
Copy link

LGTM ! Adding @morgante for merging.

@aaron-lane aaron-lane self-assigned this Dec 18, 2019
@omazin omazin requested a review from aaron-lane December 19, 2019 10:08
@omazin omazin self-assigned this Dec 19, 2019
@aaron-lane aaron-lane merged commit 5eea231 into terraform-google-modules:master Dec 19, 2019
@ocervell ocervell mentioned this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants