google folder data source #1280
Conversation
… lookup organization functionality
|
Hi @Inesci, The reason why we called the data source to search by display name For that reason, I would keep two datasources. One to retrieve the folder by id and another one to retrieve it by name. I am curious about your use case to retrieve the folder by id. If you have the id, what do you use the display_name for in your config? Thank you |
|
Hi @rosbo, It is for a module that has only the folder id, from it we need to retrieve the organization and from the organization infer the domain to then integrate with gsuite. Thanks |
|
I think it's sufficient for our use case to simply add a new data source to retrieve folder by ID. |
|
@rosbo just to double check, the only pending task is to remove the query part of this new data source? |
|
@lnesci your use case makes sense. Thanks for the clarification. Yes, removing the query part of the new data source is the only thing left before I give my 👍 |
|
$ make testacc TEST=./google TESTARGS='-run=TestAccDataSourceGoogleFolder_' GOOGLE_USE_DEFAULT_CREDENTIALS=true GOOGLE_FOLDER=886025180534 GOOGLE_PROJECT=base-project-196723 GOOGLE_REGION=us-central1 GOOGLE_ORG=65779779009 |
|
@rosbo code updated, please let me know if something needs to be modified. |
| The following arguments are supported: | ||
|
|
||
| * `folder` (Required) - The name of the Folder in the form `{folder_id}` or `folders/{folder_id}`. | ||
| * `lookup_organization` (Optional) - `true` to find the organization that the folder belongs, `false` to avoid the lookup. It searches up the tree. |
There was a problem hiding this comment.
Can you document whether it is set to true or false by default?
|
|
||
| func testAccCheckGoogleFolder_attributesCheckConfig(parent string, displayName string) string { | ||
| return fmt.Sprintf(` | ||
| resource "google_folder" "foobar" { |
There was a problem hiding this comment.
You should create a new folder in the other tests above too instead of using GOOGLE_FOLDER.
To make test run faster, and reduce the number of new folders our tests generate, using GOOGLE_FOLDER is a good idea. However, I suggest we do this in a separate PR since we will need to update our CI server config and GCP account to create and reuse that folder. We should also update the active_folder_data source test.
I filed an issue #1295 to track this.
|
@rosbo requested changes done in commit 432a9de. $ make testacc TEST=./google TESTARGS='-run=TestAccDataSourceGoogleFolder_' GOOGLE_USE_DEFAULT_CREDENTIALS=true GOOGLE_PROJECT=base-project-196723 GOOGLE_REGION=us-central1 GOOGLE_ORG=65779779009 Please let me know if something else needs to be modified. Thanks! |
|
Thanks for your contribution! Merging. |
* adding google folder data source with get by id, search by fields and lookup organization functionality * removing search functionality * creating folders for each test and updating documentation with default values
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Created to solve #1269 .
The code is based on current organization and active_folder data source but to unify it looks like organization data source.
It support get by id, search by fields (for example ACTIVE + parent + display name) and lookup organization (it searches up the tree in case there are sub folders, not just the parent).
This is my first contribution, I hope is welcome and please let me know if I need to modify something.
Thanks!