Skip to content

docs(options): refactor options layout in modules #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 19, 2025

Conversation

mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented May 13, 2025

  • docs(newtworks): merge into same page
  • docs: fix example about from-dockerfile
  • docs(menu): reorder
  • docs: reorg functional opts
  • docs(options): document when generic options were added
  • docs(options): simplify since version
  • chore: update docs template in modulegen
  • docs: line ending
  • docs(options): link list to the source
  • docs: document the contribution process for new options
  • docs(options): group by type
  • docs(options): reduce heading
  • docs: remove wrong entry in modules
  • docs(options): add versions to all module options

What does this PR do?

It refactors the current layout for the options in modules:

  • before: we have all the options, directly embedded into the container options, without a consistent order
  • after: there is a list of options, grouped by category, that goes right after the module's options, when they exist.

As a consequence, a new list include markdown file exists, with a reference to the real list of options.

I know it could be more work to maintain them, but I see the changed layout more effective in presenting the options.

Besides that, this PR is adding all versions in which the options were added, the generic and the module ones.

Render URL (options, detailed): https://deploy-preview-3163--testcontainers-go.netlify.app/features/creating_container/#basic-options

Render URL (options, list): https://deploy-preview-3163--testcontainers-go.netlify.app/modules/postgres/#basic-options

At the same time, for simplicity, the version markers in HTML have been simplified, as there is no need to include the testcontainers-go marker. The release scripts have been updated in consequence.

Finally, I'm reordering the Features menu, so that the more important features goes first.

Why is it important?

Better information architecture, presenting the module options first, followed by groups with the generic options.

@mdelapenya mdelapenya requested a review from a team as a code owner May 13, 2025 23:21
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label May 13, 2025
@mdelapenya mdelapenya self-assigned this May 13, 2025
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label May 13, 2025
@mdelapenya mdelapenya requested a review from stevenh May 13, 2025 23:21
Copy link

netlify bot commented May 13, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 949eb87
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-go/deploys/682b1a19772af2000849a022
😎 Deploy Preview https://deploy-preview-3163--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mdelapenya mdelapenya merged commit b59c9bb into testcontainers:main May 19, 2025
23 checks passed
@mdelapenya mdelapenya deleted the refactor-options-in-docs branch May 19, 2025 16:31
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jun 2, 2025
* main:
  feat(couchbase): adding auth to couchbase initCluster functions to support container reuse (testcontainers#3048)
  chore(deps): bump github.com/containerd/containerd/v2 (testcontainers#3167)
  docs(options): refactor options layout in modules (testcontainers#3163)
  fix(ci): do not run sonar for Testcontainers Cloud (testcontainers#3166)
  chore(ci): do not fail fast in the Testcontainers Cloud run (testcontainers#3164)
  feat: support adding wait strategies as functional option (testcontainers#3161)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jun 3, 2025
* main: (236 commits)
  feat(kafka,redpanda): support for waiting for mapped ports without external checks (testcontainers#3165)
  chore: bump ryuk to 0.12.0 (testcontainers#3195)
  feat!: add options when creating RawCommand (testcontainers#3168)
  chore(deps)!: bump github.com/docker/docker from 28.1.1+incompatible to 28.2.2+incompatible (testcontainers#3194)
  feat(couchbase): adding auth to couchbase initCluster functions to support container reuse (testcontainers#3048)
  chore(deps): bump github.com/containerd/containerd/v2 (testcontainers#3167)
  docs(options): refactor options layout in modules (testcontainers#3163)
  fix(ci): do not run sonar for Testcontainers Cloud (testcontainers#3166)
  chore(ci): do not fail fast in the Testcontainers Cloud run (testcontainers#3164)
  feat: support adding wait strategies as functional option (testcontainers#3161)
  fix(etcd): expose ports for the etcd nodes (testcontainers#3162)
  fix(wait): no port to wait for (testcontainers#3158)
  feat: add more functional options for customising containers (testcontainers#3156)
  docs(redpanda): update sasl authentication option to use scram sha 256 (testcontainers#3126)
  chore(deps): bump mkdocs-include-markdown-plugin from 6.2.2 to 7.1.5 (testcontainers#3137)
  chore(deps): bump github.com/shirou/gopsutil/v4 from 4.25.1 to 4.25.4 (testcontainers#3133)
  chore(deps): bump github.com/docker/docker from 28.0.1+incompatible to 28.1.1+incompatible (testcontainers#3152)
  feat(memcached): add memcached module (testcontainers#3132)
  fix(etcd): single node etcd cluster access (testcontainers#3149)
  feat(valkey): add TLS support for Valkey (testcontainers#3131)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant