Skip to content

[docs] Update localstack version #8515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Apr 7, 2024

@sullis sullis requested a review from a team as a code owner April 7, 2024 16:08
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a good catch, let's improve the docs by adding a code snippet from test's source code.

Comment on lines 9 to 13
```java
DockerImageName localstackImage = DockerImageName.parse("localstack/localstack:0.11.3");
DockerImageName localstackImage = DockerImageName.parse("localstack/localstack:3.3.0");

@Rule
public LocalStackContainer localstack = new LocalStackContainer(localstackImage)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually code snippets are provided from the test source code. Looks like this is not happening for LocalStack docs. Can you update the PR doing so?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sullis do you mind updating the PR?

@eddumelendez eddumelendez added this to the next milestone Aug 14, 2024
@eddumelendez eddumelendez changed the title fix localstack doc [docs] Update localstack version Aug 14, 2024
@eddumelendez eddumelendez merged commit e7f8af5 into testcontainers:main Aug 14, 2024
7 of 8 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution @sullis !

fokion pushed a commit to fokion/testcontainers-java that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants