-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[docs] Update localstack version #8515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update localstack version #8515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is a good catch, let's improve the docs by adding a code snippet from test's source code.
docs/modules/localstack.md
Outdated
```java | ||
DockerImageName localstackImage = DockerImageName.parse("localstack/localstack:0.11.3"); | ||
DockerImageName localstackImage = DockerImageName.parse("localstack/localstack:3.3.0"); | ||
|
||
@Rule | ||
public LocalStackContainer localstack = new LocalStackContainer(localstackImage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually code snippets are provided from the test source code. Looks like this is not happening for LocalStack docs. Can you update the PR doing so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sullis do you mind updating the PR?
Thanks for your contribution @sullis ! |
Co-authored-by: Eddú Meléndez Gonzales <[email protected]>
Reference:
https://hub.docker.com/r/localstack/localstack/tags