Skip to content

Fix typo in README.md #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Fix typo in README.md #62

merged 1 commit into from
Oct 4, 2018

Conversation

r-walsh
Copy link
Contributor

@r-walsh r-walsh commented Oct 4, 2018

What:

toBeThruthy -> toBeTruthy

Why:

How:

I started by backspacing the extra h. Then I opened this PR.

Checklist:

  • Documentation
  • Tests N/A
  • Updated Type Definitions N/A
  • Ready to be merged
  • Added myself to contributors table N/A

@smacpherson64
Copy link
Collaborator

Hahaha! Great gif! 😂

@smacpherson64 smacpherson64 merged commit 99d1442 into testing-library:master Oct 4, 2018
@r-walsh r-walsh deleted the patch-1 branch October 4, 2018 16:46
@smacpherson64
Copy link
Collaborator

Thank you @r-walsh!

@gnapse
Copy link
Member

gnapse commented Oct 4, 2018

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gnapse
Copy link
Member

gnapse commented Oct 4, 2018

@smacpherson64 not a big deal, but when something's just updating documentation, then is best to prefix the commit with docs: ... instead of fix: .... Otherwise this generates a new release that doesn't really brings something new or any fix (functionality-wise).

Again, not at all a big deal, just FYI for the future. This extra release does not hurt anyway 😄.

@gnapse
Copy link
Member

gnapse commented Oct 4, 2018

Oh and thanks @r-walsh! That's certainly not a word, haha!

@gnapse
Copy link
Member

gnapse commented Oct 4, 2018

I wonder if it would be possible to run tests on a README's code examples? 🤔 :mind_blown: 😆

@smacpherson64
Copy link
Collaborator

Sorry @gnapse! Will do!

@smacpherson64
Copy link
Collaborator

Hrm, that would be incredible!

@kentcdodds
Copy link
Member

I wonder if it would be possible to run tests on a README's code examples? 🤔 :mind_blown: 😆

I'm pretty sure there are modules for this... Someone tried to convince me to use it but it seemed like too much work...

@gnapse
Copy link
Member

gnapse commented Oct 4, 2018

Of course there are modules for that (or anything). This is javascript after all 😆.

But no, really, I'm (a bit) surprised anyway.

And yeah, agree it may be too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants