Add a definition for TextMatch #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 18 18
=====================================
Hits 18 18Continue to review full report at Codecov.
|
|
Oops. Could you rebase and resolve merge conflicts? Just did the one in |
|
Hope I did it right... I was trying to actually rebase it rather than push another commit on but I came a little unstuck. Thanks for this library! |
… with it. docs: remove unnecessary variable in the fireEvent documentation (testing-library#51)
# Conflicts: # .all-contributorsrc # README.md
|
Sorry, tried again but it seems when I rebased the upstream changes it always thinks there is a conflict. |
kentcdodds
approved these changes
Apr 11, 2018
julienw
pushed a commit
to julienw/react-testing-library
that referenced
this pull request
Dec 20, 2018
* Fix query function names in example Some function names in the example don't match the element. * Add me as a contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Update typings by adding a
TextMatchtype.Why:
TypeScript consumers cannot use RegExp or functions in the query helpers, due to the argument being typed as string-only.
How:
Add a
TextMatchtype and replaced thestringargument type for the various query helpers with it.Checklist: