Skip to content

[Feature request] Add support for proc_* #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoniJnm opened this issue May 3, 2023 · 1 comment
Closed

[Feature request] Add support for proc_* #424

JoniJnm opened this issue May 3, 2023 · 1 comment

Comments

@JoniJnm
Copy link

JoniJnm commented May 3, 2023

Could be a good idea?

Note: proc_nice exists:

safe/generated/exec.php

Lines 95 to 102 in 3a6e43b

function proc_nice(int $priority): void
{
error_clear_last();
$safeResult = \proc_nice($priority);
if ($safeResult === false) {
throw ExecException::createFromPhpError();
}
}

@shish shish added enhancement New feature or request missing function and removed enhancement New feature or request labels Feb 3, 2025
shish added a commit that referenced this issue Feb 6, 2025
shish added a commit that referenced this issue Feb 7, 2025
shish added a commit that referenced this issue Feb 7, 2025
shish added a commit that referenced this issue Feb 7, 2025
I can't figure out in what situations this actually breaks, and thus how to test it...
shish added a commit that referenced this issue Feb 7, 2025
shish added a commit that referenced this issue Feb 7, 2025
I can't figure out in what situations this actually breaks, and thus how to test it...
@shish
Copy link
Collaborator

shish commented Feb 7, 2025

proc_open is added -- proc_close seems like the return code depends on compilation flags and is generally unreliable, and even in ideal conditions I can't figure out how to make it return an error, so I'll not add that for now. If somebody can come up with a unit test which demonstrates what is necessary to make proc_close return -1, then we can add it :)

@shish shish closed this as completed Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants