Ignore the already safe date() function

[cedric-anne]

In PHP < 8.0, passing an invalid timestamp parameter value to the date() function was triggering a warning and a false value was returned.

// PHP 7.4

var_dump(date('Y-m-d', 'not-a-date'));
// Warning: date() expects parameter 2 to be int, string given in Command line code on line 1
// bool(false)

Since PHP 8.0, an error is thrown in this specific case.

// PHP 8.0

var_dump(date('Y-m-d', 'not-a-date'));
// Fatal error: Uncaught TypeError: date(): Argument #2 ($timestamp) must be of type ?int, string given in Command line code:1

Still, the corresponding PHP doc has only been fixed in PHP 8.4 and remained Returns a formatted date string. If a non-numeric value is used for <parameter>timestamp</parameter>, &false; is returned and an <constant>E_WARNING</constant> level error is emitted. in previous PHP 8.x version.

[cedric-anne]

I put this back to draft to make a unique PR with all the fixes, in order to prevent conflicting PRs.

[silasjoisten]

@cedric-anne thank you! Can you please split this PR for each function into a different PR?

[cedric-anne]

@cedric-anne thank you! Can you please split this PR for each function into a different PR?

I can, but they will conflict each other, so I will wait for each one to be merged before opening the next one. First one is #666 .

[silasjoisten]

@cedric-anne ready when you are ;)

[silasjoisten]

refs #666
refs #668
refs #669

[cedric-anne]

I rebased the current PR to include only the initial date() function fix.

[silasjoisten]

Good Job thanks!

[silasjoisten]

released in v3.2.0