-
Notifications
You must be signed in to change notification settings - Fork 339
Topology2: Add nocodec DP core 1 test topologies for MTL, LNL, and PTL #10009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topology2: Add nocodec DP core 1 test topologies for MTL, LNL, and PTL #10009
Conversation
This commit creates three new topologies, sof-mtl-nocodec-dp-core-test.tplg, sof-lnl-nocodec-dp-core-test.tplg, and sof-ptl-nocodec-dp-core-test.tplg. They are otherwise the same as the corresponding standard nocodec topologies, but both the src.11.1 on SSP2_Playback and src.5.1 on SSP2 Capture have scheduler_domain attribute set to "DP" and core_id to 1. This configuration executes SRC components for playback and capture to/from hw:0,2 on DSP core 1 in Data Processing mode, while the rest of the SSP2 pipelines are executed on DSP core 2. Signed-off-by: Jyri Sarha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- tools/topology/topology2/cavs-nocodec.conf: Language not supported
- tools/topology/topology2/development/tplg-targets.cmake: Language not supported
Oh an this thesofproject/linux#5382 is needed for this PR to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to disabled any part of this until the memory free assert() is fixed ? @jsarha is there a GH issue for this ?
@lgirdwood , now there is: #10024 I do not think we need to disable anything before we have the resulting topology and case added to our CI test plan. E.g. It should be safe to add these custom topologies as long as they are not used for anything but reproducing the bug. |
@lgirdwood , what should we do about this PR? I could move the pipelines around between the cores in the topology a bit, to it to work despite #10024 , if we want to add a passing case to our CI. Or we can merge this and also the workaround (stop using virtual heaps), or we can wait @marcinszkudlinski to come up with a proper fix. |
@jsarha lets wait for @marcinszkudlinski fix. |
@lgirdwood , the fix [1] is now merged, so maybe we should move forward with this? [1] #10044 |
SOFCI TEST |
This commit creates three new topologies, sof-mtl-nocodec-dp-core-test.tplg, sof-lnl-nocodec-dp-core-test.tplg, and sof-ptl-nocodec-dp-core-test.tplg.
They are otherwise the same as the corresponding standard nocodec topologies, but both the src.11.1 on SSP2_Playback and src.5.1 on SSP2 Capture have scheduler_domain attribute set to "DP" and core_id to 1.
This configuration executes SRC components for playback and capture to/from hw:0,2 on DSP core 1 in Data Processing mode, while the rest of the SSP2 pipelines are executed on DSP core 2.