Skip to content

Topology2: Add nocodec DP core 1 test topologies for MTL, LNL, and PTL #10009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jsarha
Copy link
Contributor

@jsarha jsarha commented May 14, 2025

This commit creates three new topologies, sof-mtl-nocodec-dp-core-test.tplg, sof-lnl-nocodec-dp-core-test.tplg, and sof-ptl-nocodec-dp-core-test.tplg.

They are otherwise the same as the corresponding standard nocodec topologies, but both the src.11.1 on SSP2_Playback and src.5.1 on SSP2 Capture have scheduler_domain attribute set to "DP" and core_id to 1.

This configuration executes SRC components for playback and capture to/from hw:0,2 on DSP core 1 in Data Processing mode, while the rest of the SSP2 pipelines are executed on DSP core 2.

This commit creates three new topologies, sof-mtl-nocodec-dp-core-test.tplg,
sof-lnl-nocodec-dp-core-test.tplg, and sof-ptl-nocodec-dp-core-test.tplg.

They are otherwise the same as the corresponding standard nocodec
topologies, but both the src.11.1 on SSP2_Playback and src.5.1 on SSP2
Capture have scheduler_domain attribute set to "DP" and core_id to 1.

This configuration executes SRC components for playback and capture
to/from hw:0,2 on DSP core 1 in Data Processing mode, while the rest
of the SSP2 pipelines are executed on DSP core 2.

Signed-off-by: Jyri Sarha <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings May 14, 2025 21:19
@jsarha jsarha requested a review from ranj063 as a code owner May 14, 2025 21:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • tools/topology/topology2/cavs-nocodec.conf: Language not supported
  • tools/topology/topology2/development/tplg-targets.cmake: Language not supported

@jsarha
Copy link
Contributor Author

jsarha commented May 15, 2025

Oh an this thesofproject/linux#5382 is needed for this PR to work.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to disabled any part of this until the memory free assert() is fixed ? @jsarha is there a GH issue for this ?

@jsarha
Copy link
Contributor Author

jsarha commented May 19, 2025

Do we need to disabled any part of this until the memory free assert() is fixed ? @jsarha is there a GH issue for this ?

@lgirdwood , now there is: #10024

I do not think we need to disable anything before we have the resulting topology and case added to our CI test plan. E.g. It should be safe to add these custom topologies as long as they are not used for anything but reproducing the bug.

@jsarha
Copy link
Contributor Author

jsarha commented May 27, 2025

@lgirdwood , what should we do about this PR? I could move the pipelines around between the cores in the topology a bit, to it to work despite #10024 , if we want to add a passing case to our CI. Or we can merge this and also the workaround (stop using virtual heaps), or we can wait @marcinszkudlinski to come up with a proper fix.

@lgirdwood
Copy link
Member

@jsarha lets wait for @marcinszkudlinski fix.

@jsarha
Copy link
Contributor Author

jsarha commented Jun 27, 2025

@jsarha lets wait for @marcinszkudlinski fix.

@lgirdwood , the fix [1] is now merged, so maybe we should move forward with this?

[1] #10044

@lgirdwood
Copy link
Member

SOFCI TEST

@jsarha
Copy link
Contributor Author

jsarha commented Jun 30, 2025

@lyakh @kv2019i could you spare couple of minutes to review this.

@kv2019i kv2019i merged commit 8c20e6b into thesofproject:main Jul 1, 2025
39 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants