Skip to content

Commit 8a4aabf

Browse files
authored
test: update lint CI parameters (#394)
tests: update lint CI parameters Context: linting in CI (`golangci-lint`) occasionally times out on Windows (flaky). Most of the time, it's fast enough (~1min). But occasionally it hits the 3 minute timeout. It's somewhat expected that `golangci-lint` is slow: golangci/golangci-lint-action#297 This PR does 3 things: 1. Bump the timeout from 3 to 5 minutes (why solve the problem when you can band-aid it?) 2. Add the `--verbose` flag, so if we start to see this again we'll have much better information with which to figure out what specifically is taking so long. 3. Remove the patch number from the `golangci-lint` version; it's disallowed, according to the `golangci-lint` action README. Fixes #390 (for now). Signed-off-by: Zachary Newman <[email protected]> Signed-off-by: Zachary Newman <[email protected]>
1 parent 7f9beab commit 8a4aabf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,5 +65,5 @@ jobs:
6565
- name: golangci-lint
6666
uses: golangci/golangci-lint-action@537aa1903e5d359d0b27dbc19ddd22c5087f3fbc
6767
with:
68-
version: v1.49.0
69-
args: --timeout 3m
68+
version: v1.49
69+
args: --timeout 5m --verbose

0 commit comments

Comments
 (0)