Skip to content

Increase lint test timeout #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mnm678 opened this issue Sep 20, 2022 · 1 comment · Fixed by #394
Closed

Increase lint test timeout #390

mnm678 opened this issue Sep 20, 2022 · 1 comment · Fixed by #394
Labels
good first issue tests

Comments

@mnm678
Copy link
Collaborator

mnm678 commented Sep 20, 2022

I've gotten a timeout on the lint test a number of times, especially on Windows, maybe we can increase the timeout:

  Running [D:\a\_temp\f50fd665-4454-4e29-bed0-88f1343208e8\golangci-lint-1.49.0-windows-amd64\golangci-lint run --out-format=github-actions --timeout 3m] in [] ...
  level=error msg="Running error: context loading failed: failed to load packages: timed out to load packages: context deadline exceeded"
  level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
  
  Error: golangci-lint exit with code 4
  Ran golangci-lint in 181515ms
@mnm678
Copy link
Collaborator Author

mnm678 commented Sep 21, 2022

It's odd that this check is a lot slower on Windows. If anyone is inspired this might be worth looking into.

znewman01 added a commit to znewman01/go-tuf that referenced this issue Sep 21, 2022
@znewman01
tests: update lint CI parameters
767dfbe 
Context: linting in CI (`golangci-lint`) occasionally times out on
Windows (flaky). Most of the time, it's fast enough (~1min). But
occasionally it hits the 3 minute timeout. It's somewhat expected that
`golangci-lint` is slow:

golangci/golangci-lint-action#297

This PR does 3 things:

1. Bump the timeout from 3 to 5 minutes (why solve the problem when you
   can band-aid it?)
2. Add the `--verbose` flag, so if we start to see this again we'll have
   much better information with which to figure out what specifically is
   taking so long.
3. Remove the patch number from the `golangci-lint` version; it's
   disallowed, according to the `golangci-lint` action README.

Fixes theupdateframework#390 (for now).

Signed-off-by: Zachary Newman <[email protected]>
@znewman01 znewman01 mentioned this issue Sep 21, 2022
Merged
trishankatdatadog pushed a commit that referenced this issue Sep 21, 2022
@znewman01
test: update lint CI parameters (#394)
8a4aabf 
tests: update lint CI parameters

Context: linting in CI (`golangci-lint`) occasionally times out on
Windows (flaky). Most of the time, it's fast enough (~1min). But
occasionally it hits the 3 minute timeout. It's somewhat expected that
`golangci-lint` is slow:

golangci/golangci-lint-action#297

This PR does 3 things:

1. Bump the timeout from 3 to 5 minutes (why solve the problem when you
   can band-aid it?)
2. Add the `--verbose` flag, so if we start to see this again we'll have
   much better information with which to figure out what specifically is
   taking so long.
3. Remove the patch number from the `golangci-lint` version; it's
   disallowed, according to the `golangci-lint` action README.

Fixes #390 (for now).

Signed-off-by: Zachary Newman <[email protected]>

Signed-off-by: Zachary Newman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: update lint CI parameters znewman01/go-tuf
2 participants
@znewman01 @mnm678