-
Notifications
You must be signed in to change notification settings - Fork 65
JWT Auth: Extract Pub/Sub Rules from Claims + Minor Fixes and Improvements #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShvaykaD
wants to merge
15
commits into
main
Choose a base branch
from
authentication-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to authentication-fixes
Take a look at the last commit. Maybe you can find even better names for the added fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
This PR acts as an extension to the original PR: #232
It introduces support for extracting publish/subscribe authorization rules directly from JWT claims defined in the JwtMqttAuthProviderConfiguration. This enables more dynamic and flexible topic-level access control for MQTT clients in token-based authentication setups.
Use case:
The configuration now supports two optional fields: pubAuthRuleClaim and subAuthRuleClaim. When set, the broker attempts to extract corresponding lists of topic filter patterns from the specified JWT claims. These patterns are then compiled and applied as authorization rules for the MQTT client. If the claims are missing, malformed, or cannot be parsed into valid regex patterns, the system gracefully falls back to the default authRules configuration.
The fallback behavior is robust and isolated per direction: for example, if only pubAuthRuleClaim is specified, subscribe rules will continue to use the static defaults. If both are unspecified, the validator bypasses dynamic extraction entirely.
Additional Fixes and Improvements
Includes a SQL upgrade script to rename SSL to X_509 in the credentials_type column of the mqtt_client_credentials table. See commits: 48c928e 5aafe25
Removed duplicate configuration fields from the JWT authentication provider configuration to simplify the structure and avoid redundancy. See commit: 603ec02
Tests
This PR adds unit tests to verify the existing validation logic for JWT authentication provider configurations. These tests ensure that required fields are correctly checked and appropriate errors are raised for misconfigurations, making the system more robust and easier to maintain.
General checklist
Front-End feature checklist
Back-End feature checklist