Skip to content

fix send btn multiple clicks #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2024
Merged

fix send btn multiple clicks #3746

merged 2 commits into from
Dec 15, 2024

Conversation

amiraabouhadid
Copy link
Contributor

Changes

  • added setting isValidTwinID and isValid address set to false to disable btn after form is submitted

Related Issues

#3684

Tested Scenarios

  • clicking on send btn multiple times does not result in multiple transactions
  • loading on btn starts after first click
  • only 1 transaction toast is shown

Checklist

@amiraabouhadid amiraabouhadid marked this pull request as ready for review December 15, 2024 13:33
@amiraabouhadid amiraabouhadid merged commit 6fb2ab7 into development Dec 15, 2024
14 checks passed
@amiraabouhadid amiraabouhadid deleted the dev_2.7_fix_send_btn branch December 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaradel samaradel samaradel approved these changes

@maayarosama maayarosama maayarosama approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amiraabouhadid @samaradel @maayarosama