Skip to content

pull() can also return named vectors #4102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions R/pull.R
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
#'
#' @param .data A table of data
#' @inheritParams tidyselect::vars_pull
#' @param name An optional parameter that specifies the column to be used
#' as names for a named vector. Specified in a similar manner as \code{var}.
#' @export
#' @examples
#' mtcars %>% pull(-1)
Expand All @@ -19,13 +21,21 @@
#' pull()
#' }
#'
pull <- function(.data, var = -1) {
#' # Pull a named vector
#' starwars %>% pull(height, name)
#'
pull <- function(.data, var = -1, name = NULL) {
UseMethod("pull")
}
#' @export
pull.data.frame <- function(.data, var = -1) {
pull.data.frame <- function(.data, var = -1, name = NULL) {
var <- tidyselect::vars_pull(names(.data), !!enquo(var))
.data[[var]]
name <- enquo(name)
if (quo_is_null(name)) {
return(.data[[var]])
}
name <- tidyselect::vars_pull(names(.data), !!name)
set_names(.data[[var]], nm = .data[[name]])
}

# FIXME: remove this once dbplyr uses vars_pull()
Expand Down
8 changes: 7 additions & 1 deletion man/pull.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions tests/testthat/test-pull.R
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,15 @@ test_that("can extract by name, or positive/negative position", {
expect_equal(pull(df, -2), x)
expect_equal(pull(df, -2L), x)
})

test_that("can extract named vectors", {
x <- 1:10
y <- letters[x]
df <- data_frame(x = x, y = y)
xn <- set_names(x, y)

expect_equal(pull(df, x), x)
expect_equal(pull(df, x, y), xn)
expect_equal(pull(df, 1, 2), xn)
expect_equal(names(pull(df, x, y)), y)
})