-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Use {palmerpenguins} dataset in arrange() examples #7676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
A bit drifted topic: On the other hand, I believe there are reasons for dplyr (and other tidyverse packages) to switch from ggplot2 removed That said, I have no idea how the replacement should be done. basepenguins might help, but I'm not fully sure if it won't make another confusion. |
I get your point @DavisVaughan. I can indeed work on using mtcars. But I personally do think it would be nice having examples using palmerpenguins across as many tidyverse functions as possible, given the popularity of the dataset in tutorials and courses. |
I think this change is worth it, but you need to (a) put palmerpenguins in imports, not suggests (since otherwise you need to protect all the examples) and (b) load the data using I can't believe that R core changed the variable names, making the whole substitution more complicated. |
Co-authored-by: Davis Vaughan <[email protected]>
…n library() + use primary pipe examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for continuing to work on this! It's really important to get the details 100% correct in this prototype, so I appreciate you bearing with us as we deliver very detailed feedback.
Thanks for your help, I appreciate you taking the time to give very detailed feedback :-) |
Co-authored-by: Hadley Wickham <[email protected]>
Co-authored-by: Hadley Wickham <[email protected]>
- update DESCRIPTION to preserver alphabetical order - remove unrelated file from .gitignore
I added examples using the penguins dataset in the arrange() documentation