skip precompilation if Gtk4 fails to initialize #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -568,6 +568,10 @@ function __init__() | |||
| printstyled(io, "\n`using Cthulhu` is required for `$(exc.f)`"; color=:yellow) | |||
| end | |||
| end | |||
| if !Gtk4.initialized[] | |||
| error("Gtk4 not initialized") | |||
There was a problem hiding this comment.
Is this supposed to be an @error or is the return afterwards surplus?
There was a problem hiding this comment.
You're right, the return is not needed -- I just removed it.
IanButterworth
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, on a headless system ProfileView would fail to precompile because Gtk4 refused to start if the C library's
init_checkmethod failed. Gtk4 now allows it to fail, but we can't precompile because calling any C library methods without initializing the C library first causes a segmentation fault. With this PR, ProfileView checks if Gtk4 was initialized and skips precompilation if it wasn't. The cost is TTFX if precompilation was done in a headless situation (for example through an SSH connection).Fixes #219.