Investigate UdpSocket test failures #1080
Comments
Thomasdezeeuw
added a commit
to Thomasdezeeuw/mio
that referenced
this issue
Sep 8, 2019
Issues tokio-rs#1080 is opened to investigate why.
Thomasdezeeuw
added a commit
that referenced
this issue
Sep 12, 2019
Issues #1080 is opened to investigate why.
|
@Thomasdezeeuw could you please assign this issue to me. I've started working on it. |
|
Tests fail because of issue described here #1131, we need to reregister the interests after a read which emptied the sock bufffer. |
dtacalau
added a commit
to dtacalau/mio
that referenced
this issue
Nov 27, 2019
…ndows. One tests needed to have interests reregistered by calling a blocking recv. Another tests needed a Windows specific assert error message. Signed-off-by: Daniel Tacalau <[email protected]>
dtacalau
added a commit
to dtacalau/mio
that referenced
this issue
Nov 27, 2019
…ndows. One tests needed to have interests reregistered by calling a blocking recv. Another tests needed a Windows specific assert error message. Signed-off-by: Daniel Tacalau <[email protected]>
Thomasdezeeuw
pushed a commit
that referenced
this issue
Nov 30, 2019
* fixed assert arguments order Signed-off-by: Daniel Tacalau <[email protected]> * fix issue #1080, re-enabled and fixed UDP tests failing on Windows. One tests needed to have interests reregistered by calling a blocking recv. Another tests needed a Windows specific assert error message. Signed-off-by: Daniel Tacalau <[email protected]> * Added a note in the read/peek(_from) docs that on Windows if the data is larger than the buffer specified, the buffer is filled with the first part of the data, and peek returns the error WSAEMSGSIZE(10040). The excess data is lost. Make sure to always use a sufficiently large buffer to hold the maximum UDP packet size, which can be up to 64 kilobytes in size. Signed-off-by: Daniel Tacalau <[email protected]> * Added two new tests verifying ET behavior for UDP sockets events. These tests rely on having a blocking recv(_from) reregistering the socket and reseting the interests. Signed-off-by: Daniel Tacalau <[email protected]> * replaces 64 kilobytes with 65536 bytes in the notes Signed-off-by: Daniel Tacalau <[email protected]> * changes after review for new et tests: removed unneeded block, expect a writable before actual write Signed-off-by: Daniel Tacalau <[email protected]>
|
Fixed by #1167. @Thomasdezeeuw this can be closed. |
dtacalau
added a commit
to dtacalau/mio
that referenced
this issue
Dec 4, 2019
…kio-rs#1167) * fixed assert arguments order Signed-off-by: Daniel Tacalau <[email protected]> * fix issue tokio-rs#1080, re-enabled and fixed UDP tests failing on Windows. One tests needed to have interests reregistered by calling a blocking recv. Another tests needed a Windows specific assert error message. Signed-off-by: Daniel Tacalau <[email protected]> * Added a note in the read/peek(_from) docs that on Windows if the data is larger than the buffer specified, the buffer is filled with the first part of the data, and peek returns the error WSAEMSGSIZE(10040). The excess data is lost. Make sure to always use a sufficiently large buffer to hold the maximum UDP packet size, which can be up to 64 kilobytes in size. Signed-off-by: Daniel Tacalau <[email protected]> * Added two new tests verifying ET behavior for UDP sockets events. These tests rely on having a blocking recv(_from) reregistering the socket and reseting the interests. Signed-off-by: Daniel Tacalau <[email protected]> * replaces 64 kilobytes with 65536 bytes in the notes Signed-off-by: Daniel Tacalau <[email protected]> * changes after review for new et tests: removed unneeded block, expect a writable before actual write Signed-off-by: Daniel Tacalau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #1070 tests that are ignored on Windows.
The text was updated successfully, but these errors were encountered: