Update minimum Rustc version (MSVR) to 1.46.0 #1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses `features = "..."`, which should have been `feature = "..."` (not ending with an 's').
|
Tokio's minimum supported Rust version is currently 1.45, and the precedent is that it requires a breaking change to update. Edit: apparently the policy is six months, although that's not mentioned in the README. So it might be OK after all. |
|
It is mentioned in the release blog post: https://tokio.rs/blog/2020-12-tokio-1-0 Would be good to add it to the readme too. |
|
If someone can give this a +1 than I'm merging it. Tokio can start using Mio v0.8 after Feb 26th in compliance with the 6 month policy. |
Darksonn
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustc was release on 27th of August 2020: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1460-2020-08-27, the main benefit was additional support for
constfunctions and#[track_caller]attribute.This is also required for socket2, which currently requires 1.42.