Use socket2::Socket for TcpStream #1442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a single breaking change which involves multiple UdpSocket methods: the receive methods now accept an uninitialised buffer ([MaybeUninit<u8>]), rather than an initialised one. This is the case of the following methods: * UdpSocket::recv_from * UdpSocket::peek_from * UdpSocket::recv * UdpSocket::peek This allows higher level libraries, such as Tokio or Heph, to use uninitialised buffers if they want to. Note that the API guarantees not to write any uninitialised data to the buffer, so it's not unsound to pass `&[u8]` to the methods. Finally this adds a debug assertions to UdpSocket::recv_from that checks if the buffer passed isn't zero sized. Passing a zero sized buffer to recv_from causes the OS to not initialise the source address (at least on macOS), which in turn causes a misleading error to be returned saying the address family is invalid. Before this change didn't check this and likely returned an invalid IPv6 address.
This includes a single breaking change TcpStream::peek now now accepts an uninitialised buffer ([MaybeUninit<u8>]), rather than an initialised one. This also add TcpStream::recv which is the same as the io::Read::read implementation, but accept an unitialised buffer.
|
We're not adding socket2 as Mio dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a single breaking change TcpStream::peek now now accepts
an uninitialised buffer ([MaybeUninit]), rather than an initialised
one.
This also add TcpStream::recv which is the same as the io::Read::read
implementation, but accept an unitialised buffer.
Depends on #1431.