add option to turn on/off version check #9
Conversation
| @@ -37,8 +37,10 @@ public function connect( | |||
| ); | |||
| } | |||
| } | |||
| // some cloud memcached service don't return correct version, so skip version check. | |||
| $checkVersion = in_array("check_version",$options) ? $options["check_version"] : FALSE; | |||
There was a problem hiding this comment.
- No space found after comma in function call
- TRUE, FALSE and NULL must be lowercase; expected
falsebut foundFALSE
| @@ -97,15 +99,15 @@ protected function setCredentials($memcached, $credentials) | |||
| * @param \Memcached $memcached | |||
| * @return \Memcached | |||
| */ | |||
| protected function validateConnection($memcached) | |||
| protected function validateConnection($memcached, $checkVersion=TRUE) | |||
There was a problem hiding this comment.
- Incorrect spacing between argument
$checkVersionand equals sign; expected 1 but found 0 - Incorrect spacing between default value and equals sign for argument
$checkVersion; expected 1 but found 0 - TRUE, FALSE and NULL must be lowercase; expected
truebut foundTRUE
| @@ -21,7 +21,8 @@ class MemcachedConnector | |||
| */ | |||
| public function connect( | |||
| array $servers, $connectionId = null, | |||
| array $options = [], array $credentials = [] | |||
| array $options = [], array $credentials = [], | |||
There was a problem hiding this comment.
Multi-line function declarations must define one parameter per line
| @@ -97,15 +98,15 @@ protected function setCredentials($memcached, $credentials) | |||
| * @param \Memcached $memcached | |||
| * @return \Memcached | |||
| */ | |||
| protected function validateConnection($memcached) | |||
| protected function validateConnection($memcached, $checkVersion=true) | |||
There was a problem hiding this comment.
- Incorrect spacing between argument
$checkVersionand equals sign; expected 1 but found 0 - Incorrect spacing between default value and equals sign for argument
$checkVersion; expected 1 but found 0
|
@khsing this package supports memcached servers using ext-memcached. I would suggest any memcached servers returning invalid version information do not conform to the protocol and therefore are unsupported. If you would like to follow this up I would ask that you provide further information on the cloud provider in question. Thanks |
|
@tomcastleman I am using Aliyun OCS service as memcached alternative service, which build up with alibaba/tair. Aliyun OCS does not return memcached version, but totally compatible with memcached protocol. |
|
Possibly related laravel/framework issue. |
|
@tomcastleman yes, same issues. ;-) |
|
Fixed in #10 |
for some cloud memcached service doesn't return correct version, but function is normal. Add a option able to skip version check. default version check is enable.