Skip to content

Support official .yaml extension for YAML files #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

vcschapp
Copy link
Contributor

Description

This trivial change enables support for the .yaml file extension, which is the official file extension for YAML per the YAML FAQ.

Testing

No new tests added, but existing ones pass:

$ npm test
...
Test Suites: 9 passed, 9 total
Tests:       44 passed, 44 total
Snapshots:   0 total
Time:        1.604 s, estimated 2 s
Ran all test suites.

Copy link
Owner

@tomcollins tomcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vcschapp. Thanks for raising this PR. The change looks fine.

We probably want to update this line for completeness:

(value.match(/^(.+)#/) || value.match(/^(.+)\.(json|yml)$/))

But happy to approve as things stand.

@tomcollins tomcollins merged commit 21827af into tomcollins:master Mar 22, 2023
@tomcollins
Copy link
Owner

I make the renderer change in #101

@vcschapp vcschapp deleted the add-yaml-file-extension branch March 23, 2023 18:05
@vcschapp
Copy link
Contributor Author

Thanks @tomcollins !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants