-
Notifications
You must be signed in to change notification settings - Fork 567
burn-import: add some tests for ConstantNode #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
==========================================
+ Coverage 80.84% 80.91% +0.06%
==========================================
Files 872 872
Lines 120725 121039 +314
==========================================
+ Hits 97605 97938 +333
+ Misses 23120 23101 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR has been marked as stale because it has not been updated for over a month |
756fd3c
to
a1f87b8
Compare
This reverts commit b6631ba.
a1f87b8
to
7291b0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was going through pending PRs, figured I'd apply the suggested changes myself 😅 so we can finally close this
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
I've been trying to implement OneHot ONNX op (#1714) in a WIP draft branch. The ONNX model ends up containing a constant integer vector
values=[0, 1]
used by the OneHot op, this vector was causing issues when trying to test the model. I looked atConstantNode
and these are the tests so far I could get working while investigating.Issues for
ConstantNode
#2624 - constant tensors aren't populated with values
#2625 - generated code for const int tensors doesn't compile
Changes
ConstantNode::tensor_ty_tokens
for tests, but this PR otherwise shouldn't be changing howConstantNode
currently worksTesting
Ran added tests
I checked the .onnx models contain the expected scalar constants using Netron
Screenshots