Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadowing and inlining JsqlParser library. #35

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Shadowing and inlining JsqlParser library. #35

merged 1 commit into from
Jul 5, 2023

Conversation

onukristo
Copy link
Contributor

@onukristo onukristo commented Jul 5, 2023 •
edited
Loading

Context

Changed

Basically spring-data has a questionable mechanism, which activates when it detects jsqlparser lib in classpath.
So far we overwrote this mechanism via ByteBuddy.

However the bytebuddy can not redefine classes in the presence of Jacoco and JDK 17.

Checklist

@onukristo onukristo added the change:standard Not an emergency or impactful change label Jul 5, 2023
@onukristo onukristo requested a review from a team as a code owner July 5, 2023 09:00
@onukristo onukristo merged commit 26bdaf6 into master Jul 5, 2023
@mscott-tw mscott-tw deleted the shaded_sql_parser branch February 15, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajmalab ajmalab ajmalab approved these changes

Assignees
No one assigned
Labels
change:standard Not an emergency or impactful change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onukristo @ajmalab