Skip to content

Add download pseudo translations flag #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Add download pseudo translations flag #131

merged 1 commit into from
Nov 17, 2022

Conversation

codegaze
Copy link
Contributor

@codegaze codegaze commented Nov 17, 2022

This uses the pseudo attribute in API to download
files with pseudo translations.

The change is on the pull command, in which, if
pseudo flag is true we use the source file
download instead of the translations file download
because for compatibility issues. The pseudo
attribute will be removed from the API for translations
in the future and will be used only in source.

@codegaze codegaze force-pushed the add-pseudo branch 2 times, most recently from 6d573b2 to 1fdaaba Compare November 17, 2022 10:59
This uses the `pseudo` attribute in API to download
files with pseudo translations.

The change is on the pull command, in which, if
`pseudo` flag is true we use the source file
download instead of the translations file download
because for compatibility issues. The `pseudo`
attribute will be removed from the API for translations
in the future and will be used only in source.
Copy link

@kbairak kbairak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job man. Let me give it a quick test and I'll approve.

Copy link

@kbairak kbairak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!!! 🚀 👍

➜  txtest tx pull -t -l or_IN --pseudo --force
# Getting info about resources

kb_clitest.en_1_json - Done
[##############################] (1 / 1)

# Pulling files

kb_clitest.en_1_json [or_IN] - Done
[##############################] (1 / 1)
➜  txtest head or_IN_1.json
{
  "key_0": "[şǿŭřƈḗ_0 ϵııſϕLjΰDz]",
  "key_1": "[şǿŭřƈḗ_1 ẛϑDzLj靐Njϐϱ]",
  "key_2": "[şǿŭřƈḗ_2 LjΰΰϱϰDžϖϐ]",
  "key_3": "[şǿŭřƈḗ_3 ϑ鶱NjDžϖϕſΐ]",
  "key_4": "[şǿŭřƈḗ_4 ϕ鶱ΰϰϰϐςϱ]",
  "key_5": "[şǿŭřƈḗ_5 LjDžẛς衋衋ΐΰ]",
  "key_6": "[şǿŭřƈḗ_6 ϑϵ鶱ϵϑſ靐Lj]",
  "key_7": "[şǿŭřƈḗ_7 ẛ鶱ςςLjı鶱靐]",
  "key_8": "[şǿŭřƈḗ_8 靐鶱ΐẛςΰ靐ı]",

@codegaze codegaze merged commit 28d9244 into devel Nov 17, 2022
@codegaze codegaze deleted the add-pseudo branch November 17, 2022 11:50
@codegaze codegaze mentioned this pull request Nov 17, 2022
@vinay-vts
Copy link

tx pull --pseudo --force is downloading the pseudo content in target language files, while it suppose to create or update en_pseudo.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants