Bad resume #5
Open
Bad resume #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r object; - Fix: Remove repeated attempt after block event as not working in browser testing; - Fix: Polyfill delete's `newVersion` for Firefox (and add tests); - Fix: Polyfill PhantomJS' `del` success event, resumed and otherwise (and add tests); - Fix: preventDefault within error handlers to avoid bubbling of errors beyond catch; - Feature: Support resumption of blocked events via `resume` property (and add docs and tests); - Feature: Pass on event object to `del` `onsuccess`; - Testing feature: Separate zuul from local testing; - Testing: Extend timeout for Firefox - Testing: Add delete test (with checks for its success event)
…r object; - Fix: Remove repeated attempt after block event as not working in browser testing; - Fix: Polyfill delete's `newVersion` for Firefox (and add tests); - Fix: Polyfill PhantomJS' `del` success event, resumed and otherwise (and add tests); - Fix: preventDefault within error handlers to avoid bubbling of errors beyond catch; - Feature: Support resumption of blocked events via `resume` property (and add docs and tests); - Feature: Pass on event object to `del` `onsuccess`; - Testing feature: Separate zuul from local testing; - Testing: Extend timeout for Firefox - Testing: Add delete test (with checks for its success event)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't actually want you to merge this PR, but am providing to highlight that for some reason, Chrome, Firefox, and PhantomJS don't handle the tests properly if I try to keep your 100ms delay feature along with my
resumeability.When I try logging, the second time making the request (after the delay), although the handlers are added to the request object, none of them fire.