Skip to content

Throw in upgrade #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Apr 14, 2016

Builds on prior PRs to:

  • Allow upgrade argument to throw its own error to be catchable on the open() promise chain (and add test and docs)

@brettz9 brettz9 force-pushed the throw-in-upgrade branch 2 times, most recently from 1a7bf83 to 0921dcf Compare April 16, 2016 07:09
brettz9 added 3 commits April 23, 2018 07:26
…r object;

- Fix: Remove repeated attempt after block event as not working in browser testing;
- Fix: Polyfill delete's `newVersion` for Firefox (and add tests);
- Fix: Polyfill PhantomJS' `del` success event, resumed and otherwise (and add tests);
- Fix: preventDefault within error handlers to avoid bubbling of errors beyond catch;
- Feature: Support resumption of blocked events via `resume` property (and add docs and tests);
- Feature: Pass on event object to `del` `onsuccess`;
- Testing feature: Separate zuul from local testing;
- Testing: Extend timeout for Firefox
- Testing: Add delete test (with checks for its success event)
…r object;

- Fix: Remove repeated attempt after block event as not working in browser testing;
- Fix: Polyfill delete's `newVersion` for Firefox (and add tests);
- Fix: Polyfill PhantomJS' `del` success event, resumed and otherwise (and add tests);
- Fix: preventDefault within error handlers to avoid bubbling of errors beyond catch;
- Feature: Support resumption of blocked events via `resume` property (and add docs and tests);
- Feature: Pass on event object to `del` `onsuccess`;
- Testing feature: Separate zuul from local testing;
- Testing: Extend timeout for Firefox
- Testing: Add delete test (with checks for its success event)
…`open()` promise chain (and add test and docs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant