Skip to content

Error if diff folder exists, normalize ref path #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2024
Merged

Error if diff folder exists, normalize ref path #25

merged 2 commits into from
Sep 11, 2024

Conversation

briank-git
Copy link
Collaborator

@briank-git briank-git commented Sep 11, 2024 •
edited
Loading

Closes #19.

  • Simple error is now thrown if diff folder exists, no more complicated stack trace.

Closes #21.

  • Normalize the ref path before the comparisons so links are properly highlighted. On certain websites the path contained './' in front of the path meaning the following list comparisons would fail as those paths do not have that prepended.

@briank-git briank-git changed the title Error if diff folder exists, normalize href path Error if diff folder exists, normalize ref path Sep 11, 2024
@briank-git briank-git merged commit 975dafb into main Sep 11, 2024
@briank-git briank-git deleted the fix-issue-19-21 branch September 11, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link colouring for <a> tags with subelements error if diff folder already exists
1 participant
@briank-git