Skip to content

added a new macro 'utarray_replace' to replace an element in array' #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xunicatt
Copy link
Contributor

No description provided.

@Quuxplusone
Copy link
Collaborator

Right now this patch is (1) missing tests and documentation, and (2) missing a semicolon, so once you add a test using your new macro, that test will fail to compile.
I think we shouldn't merge this unless it's useful to someone (such as yourself). If it's useful, you must be using it. If you're using it, you must be able to provide some code that demonstrates its use. Put that code into a new test case. And then, make sure it compiles and does the right thing at runtime! Right now you're failing the "it compiles" check.

@xunicatt
Copy link
Contributor Author

xunicatt commented Mar 1, 2025

Thanks for the response and clarification, I will open a new pull request once I fix those issues.

@xunicatt xunicatt closed this Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants