{stream,transport}: fix connection overwriting when a client uses the same port to connect. #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… same port to connect. The server's transport maintains an `addrToConn` map based only on the client's IP-Port. When a client connects to different ports on the server using the same local IP-port, it causes the connections in the server transport's `addrToConn` map to be overwritten, leading to a "Can't find conn by addr" error in the streaming service. So now, the combination of the client's IP-Port and the server's IP-Port is used as the `addrToConn` map key.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
===================================================
- Coverage 85.60258% 85.46797% -0.13462%
===================================================
Files 188 189 +1
Lines 16114 16123 +9
===================================================
- Hits 13794 13780 -14
- Misses 1755 1785 +30
+ Partials 565 558 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sandyskies
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server's transport maintains an
addrToConnmap based only on the client's IP-Port. When a client connects to different ports on the server using the same local IP-port, it causes the connections in the server transport'saddrToConnmap to be overwritten, leading to a "Can't find conn by addr" error in the streaming service.So now, the combination of the client's IP-Port and the server's IP-Port is used as the
addrToConnmap key.