-
Notifications
You must be signed in to change notification settings - Fork 112
docs: add requirements for PR labels in contribution guide #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In the future, mayby consider using the mergeable plugin to check if the PR description meets the requirements. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
===================================================
+ Coverage 85.49277% 85.71606% +0.22329%
===================================================
Files 189 189
Lines 16123 16123
===================================================
+ Hits 13784 13820 +36
+ Misses 1778 1745 -33
+ Partials 561 558 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Perhaps we can create a release guideline document first, to understand the overall process of releasing, and then add the relevant information to the contributor guide |
Sounds good! But I think we can add the release guideline later. Compared to contributors, repository maintainers are more concerned about the release process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- type/documentation: 添加文档。 | ||
- type/api-change: 添加、删除或更改 API。 | ||
- type/failing-test: CI 测试用例偶发失败。 | ||
- type/performance: 改进性能的变更。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add improvement
In order to generate the changlog quickly during the release process, PR guidelines needs to be further improved.
Improve the PR template and documentation, requiring the inclusion of release notes in the PR description and setting appropriate labels.
RELEASE NOTES: NONE