Skip to content

client: remove the write operation on *registry.Node in LoadNodeConfig to avoid data race during selecting Node #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

liuzengh
Copy link
Contributor

cherry-pick from internal code within the company

…g to avoid data race during selecting Node

cherry-pick from internal code within the company
@liuzengh liuzengh requested a review from tocrafty November 10, 2023 09:26
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf5ca25) 85.80909% compared to head (a7a6ef1) 85.72580%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main        #138         +/-   ##
===================================================
- Coverage   85.80909%   85.72580%   -0.08329%     
===================================================
  Files            189         189                 
  Lines          16123       16127          +4     
===================================================
- Hits           13835       13825         -10     
- Misses          1736        1740          +4     
- Partials         552         562         +10     
Flag Coverage Δ
unittests 85.72580% <100.00000%> (-0.08329%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/client.go 86.62791% <100.00000%> (ø)
client/options.go 88.38527% <ø> (-0.06543%) ⬇️
client/stream.go 77.90698% <100.00000%> (+1.65698%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandyskies sandyskies merged commit c2bdf24 into trpc-group:main Nov 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
@sandyskies sandyskies added the type/bug Fixes a newly discovered bug label Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/bug Fixes a newly discovered bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants