Skip to content

docs: add note on listen to all addresses for a service #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

WineChord
Copy link
Contributor

Fixes #143

RELEASE NOTES: NONE

@WineChord WineChord added the type/documentation Adds documentation label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (edc1105) 85.77185% compared to head (e4589f7) 85.54247%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main        #144         +/-   ##
===================================================
- Coverage   85.77185%   85.54247%   -0.22939%     
===================================================
  Files            189         189                 
  Lines          16130       16130                 
===================================================
- Hits           13835       13798         -37     
- Misses          1739        1772         +33     
- Partials         556         560          +4     
Flag Coverage Δ
unittests 85.54247% <ø> (-0.22939%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@liuzengh liuzengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sandyskies sandyskies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandyskies sandyskies merged commit 65a60b1 into trpc-group:main Dec 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/documentation Adds documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

affected/package: config.go
3 participants