Skip to content

{client, naming}: allow selector to define its own net.Addr parser #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024

Conversation

YoungFr
Copy link
Contributor

@YoungFr YoungFr commented May 14, 2024

This is used to avoid unnecessary addr parse which is commonly used
in trpc-database.

To properly update the DSN library, we need to introduce this feature into
the open-source tRPC-Go.

RELEASE NOTES: NONE

Copy link

github-actions bot commented May 14, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@YoungFr
Copy link
Contributor Author

YoungFr commented May 14, 2024

I have read the CLA Document and I hereby sign the CLA

liuzengh added a commit to trpc-group/cla-database that referenced this pull request May 14, 2024
Copy link
Contributor

@liuzengh liuzengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuzengh
Copy link
Contributor

@sandyskies need realse a new version after this pr be merged.

@sandyskies
Copy link
Contributor

Pls update the pr description @YoungFr

@YoungFr
Copy link
Contributor Author

YoungFr commented May 15, 2024

Pls update the pr description @YoungFr

done @sandyskies

@sandyskies sandyskies merged commit 82ee6e8 into trpc-group:main May 15, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
@YoungFr YoungFr deleted the YoungFr/update_registry branch May 15, 2024 07:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants