Skip to content

postman_client.IDNameUUID becomes IdNameUid #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

martinlocklear
Copy link
Contributor

@martinlocklear martinlocklear commented May 7, 2025

This is misleadingly named. This field actually represents a thing called uid, which is a field sometimes provided by the Postman API, and is usually a concatenation of a user id and an object ID. The object ID usually looks like a UUID, but this field is strictly never a UUID.

So we rename the field and the struct to (which is named based on it's fields)

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

This is misleadingly named.  This field actually represents a thing called `uid`, which is a field sometimes
provided by the Postman API, and is usually a concatenation of a user id and an object ID.  The object ID
usually looks like a UUID, but this field is strictly never a UUID.

So we rename the field and the struct to (which is named based on it's fields)
@martinlocklear martinlocklear marked this pull request as ready for review May 7, 2025 15:02
@martinlocklear martinlocklear requested review from a team as code owners May 7, 2025 15:02
Copy link
Contributor

@casey-tran casey-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Martin!

@martinlocklear martinlocklear merged commit 513d4ac into main May 7, 2025
13 checks passed
@martinlocklear martinlocklear deleted the martin/postman-uuid-rename-IDNameUUID branch May 7, 2025 19:08
abmussani added a commit to abmussani/trufflehog that referenced this pull request May 8, 2025
* main: (40 commits)
  [Feat] Detector implementation for Azure API Management Direct Management Key (trufflesecurity#3938)
  Fastly Analyzer (trufflesecurity#4082)
  Postman Code Uses Consistent Casing for Id Var Names (trufflesecurity#4124)
  Normalize UID to Uid in Postman Code (trufflesecurity#4125)
  postman_client.IDNameUUID becomes IdNameUid (trufflesecurity#4123)
  Fixed Kontent Detector (trufflesecurity#4122)
  [Fix] Added Prefix In Dockerhub Detector Regex (trufflesecurity#4084)
  Issue - 3697 - GitHub analyzer panic (trufflesecurity#4113)
  fix(test/snowflake): Snowflake flaky pattern test (trufflesecurity#4083)
  Netlify Analyzer (trufflesecurity#4106)
  Add xAI detector (trufflesecurity#4117)
  added tunnel authtoken detection in ngrok detector (trufflesecurity#4115)
  Postman increase http client timeout (trufflesecurity#4086)
  feat: bing subscription key support (trufflesecurity#4092)
  Improve precommit hook setup and support both global and repo pre-commit hooks, frameworkless and with pre-commit or husky (trufflesecurity#4098)
  Make a first pass at some structural introduction docs (trufflesecurity#4076)
  Update action.yml (trufflesecurity#4108)
  Refactor Netlify Detector (trufflesecurity#4102)
  chore: added github action custom detector name (trufflesecurity#3417)
  Fixed PubnubsubsciptionKey detector verification (trufflesecurity#4107)
  ...

# Conflicts:
#	pkg/engine/defaults/defaults.go
#	pkg/pb/detectorspb/detectors.pb.go
#	proto/detectors.proto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants