Skip to content

test(sources/s3): fix missing region error #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented May 8, 2025

Description:

Fixes #4069.

@rosecodym Apologies. I overlooked this and mistakenly assumed that the CI environment had the AWS_REGION variable set. Unfortunately, it doesn't, and that caused the failure on the main branch. This PR should fix that.

https://github.com/trufflesecurity/trufflehog/actions/runs/14910724831/job/41884134392#step:6:1277

=== FAIL: pkg/sources/s3 TestSource_Chunks/gets_chunks_after_assuming_role (unknown)
2025-05-08T16:06:01Z	info-0	context	Creating checkpointer	{"timeout": 30}
    s3_test.go:123: Source.Chunks() error = role "arn:aws:iam::619888638459:role/s3-test-assume-role" could not list any s3 buckets for scanning: operation error S3: ListBuckets, get identity: get credentials: failed to refresh cached credentials, operation error STS: AssumeRole, failed to resolve service endpoint, endpoint rule error, Invalid Configuration: Missing Region, wantErr false

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Fixes: 5f56550 ("feat(sources/s3): migrate to AWS SDK v2 (#4069)")
Signed-off-by: Eng Zer Jun <[email protected]>
@Juneezee Juneezee requested review from a team as code owners May 8, 2025 18:36
@ahrav
Copy link
Collaborator

ahrav commented May 8, 2025

Thank you @Juneezee

@ahrav ahrav merged commit 90190de into trufflesecurity:main May 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants