Skip to content

Fixed: 3D viewer shouldn't be blank when the board's dimensions are 0 #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2025

Conversation

MustafaMulla29
Copy link
Contributor

@MustafaMulla29 MustafaMulla29 commented Mar 21, 2025

/claim #214

empty-board.mp4

Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
3d-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 2:57pm

Copy link
Member

@imrishabh18 imrishabh18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks okay, see the comments. Probably a better variable naming could help

@seveibar seveibar merged commit 903f538 into tscircuit:main Mar 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants