Skip to content

Added support for uploading SimpleRouteJson #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MustafaMulla29
Copy link
Contributor

/claim #10

Before:

before.mp4

After:

after.mp4

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
circuitjson-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 8:07am

Copy link
Contributor

@ShiboSoftwareDev ShiboSoftwareDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of type any, use the simpleroutejson type
image

@MustafaMulla29
Copy link
Contributor Author

@ShiboSoftwareDev Done!

SimpleRouteJson wasn't exported by core, so had to create a new file for it.

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove package lock (make sure youre reviewing your own pr!)

@seveibar
Copy link
Contributor

seveibar commented Feb 26, 2025

@MustafaMulla29 has to be imported from core. You can patch/PR core

@MustafaMulla29 MustafaMulla29 force-pushed the feat/support-simple-route-json branch from deb7ba0 to a2e0e8f Compare February 27, 2025 08:03
@ShiboSoftwareDev ShiboSoftwareDev merged commit 9b5ed6e into tscircuit:main Feb 27, 2025
2 checks passed
@MustafaMulla29 MustafaMulla29 deleted the feat/support-simple-route-json branch February 27, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants