Skip to content

get_group_by_cols() -> list[BaseExpression] #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

get_group_by_cols() -> list[BaseExpression] #1631

merged 1 commit into from
Jul 24, 2023

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jul 24, 2023 •
edited
Loading

resolves #1623

@asottile
Copy link
Contributor Author

CI appears stuck, will need to rerun that one

sobolevn
sobolevn approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've created #1632 to add timeouts to CI. Right now I've stoped it after 2+ hours of waiting.

@adamchainz adamchainz merged commit 0b18d27 into typeddjango:master Jul 24, 2023
@adamchainz
Copy link
Contributor

Cheers m’dears

@asottile asottile deleted the patch-2 branch February 4, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamchainz adamchainz adamchainz approved these changes

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_group_by_cols does not seem to have the correct type
3 participants
@asottile @adamchainz @sobolevn